feat(backtracking): add m-coloring algorithm#13274
feat(backtracking): add m-coloring algorithm#13274sgindeed wants to merge 9 commits intoTheAlgorithms:masterfrom
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
algorithms-keeper
Bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.gh.lumenfield.work/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,39 @@ | |||
| def isSafe(node, color, graph, n, col): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: isSafe. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file backtracking/m_coloring_problem.py, please provide doctest for the function isSafe
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: isSafe
Please provide type hint for the parameter: node
Please provide type hint for the parameter: color
Please provide type hint for the parameter: graph
Please provide descriptive name for the parameter: n
Please provide type hint for the parameter: n
Please provide type hint for the parameter: col
| return True | ||
|
|
||
|
|
||
| def solve(node, col, m, n, graph): |
There was a problem hiding this comment.
Please provide return type hint for the function: solve. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file backtracking/m_coloring_problem.py, please provide doctest for the function solve
Please provide type hint for the parameter: node
Please provide type hint for the parameter: col
Please provide descriptive name for the parameter: m
Please provide type hint for the parameter: m
Please provide descriptive name for the parameter: n
Please provide type hint for the parameter: n
Please provide type hint for the parameter: graph
| return False | ||
|
|
||
|
|
||
| def graphColoring(graph, m, n): |
There was a problem hiding this comment.
Please provide return type hint for the function: graphColoring. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file backtracking/m_coloring_problem.py, please provide doctest for the function graphColoring
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: graphColoring
Please provide type hint for the parameter: graph
Please provide descriptive name for the parameter: m
Please provide type hint for the parameter: m
Please provide descriptive name for the parameter: n
Please provide type hint for the parameter: n
|
|
||
|
|
||
| @app.route("/", methods=["GET", "POST"]) | ||
| def home(): |
There was a problem hiding this comment.
Please provide return type hint for the function: home. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file other/calc.py, please provide doctest for the function home
algorithms-keeper
Bot
added
awaiting reviews
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,39 @@ | |||
| def isSafe(node, color, graph, n, col): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: isSafe. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file backtracking/m_coloring_problem.py, please provide doctest for the function isSafe
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: isSafe
Please provide type hint for the parameter: node
Please provide type hint for the parameter: color
Please provide type hint for the parameter: graph
Please provide descriptive name for the parameter: n
Please provide type hint for the parameter: n
Please provide type hint for the parameter: col
| return True | ||
|
|
||
|
|
||
| def solve(node, col, m, n, graph): |
There was a problem hiding this comment.
Please provide return type hint for the function: solve. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file backtracking/m_coloring_problem.py, please provide doctest for the function solve
Please provide type hint for the parameter: node
Please provide type hint for the parameter: col
Please provide descriptive name for the parameter: m
Please provide type hint for the parameter: m
Please provide descriptive name for the parameter: n
Please provide type hint for the parameter: n
Please provide type hint for the parameter: graph
| return False | ||
|
|
||
|
|
||
| def graphColoring(graph, m, n): |
There was a problem hiding this comment.
Please provide return type hint for the function: graphColoring. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file backtracking/m_coloring_problem.py, please provide doctest for the function graphColoring
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: graphColoring
Please provide type hint for the parameter: graph
Please provide descriptive name for the parameter: m
Please provide type hint for the parameter: m
Please provide descriptive name for the parameter: n
Please provide type hint for the parameter: n
1 participant
Describe your change:
Checklist: